PR Fixes a runtime issue for tensorflow on OSX#3729
Draft
Conversation
Signed-off-by: Sean P. Goggins <s@goggins.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses TensorFlow installation issues on macOS with Apple Silicon by introducing platform-specific dependency resolution. The changes conditionally install different TensorFlow packages based on the operating system and CPU architecture.
Changes:
- Added platform-specific markers for TensorFlow dependencies to support Linux, Intel Mac, and Apple Silicon Mac
- Replaced single TensorFlow dependency with three conditional dependencies:
tensorflowfor Linux and Intel Mac,tensorflow-macosfor Apple Silicon, andtensorflow-metalfor GPU acceleration on Apple Silicon - Updated lock file with platform-specific resolution markers and package entries
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Added conditional platform markers for TensorFlow, tensorflow-macos, and tensorflow-metal packages to support different OS/architecture combinations |
| uv.lock | Auto-generated lock file updated with expanded resolution markers and platform-specific package wheels for the new TensorFlow dependency configuration |
Signed-off-by: Sean P. Goggins <s@goggins.com>
Signed-off-by: Sean P. Goggins <s@goggins.com>
Signed-off-by: Sean P. Goggins <s@goggins.com>
sgoggins
added
deployed version
Contributor
|
so youre saying that tensorflow on arm macs requires a separate |
Member
Author
|
Maybe. I'm still working on what's breaking. I think it's one factor. There may also be a psycopg2 issue with celery. Not finished. Draft mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description