Remove quotes from format string passed to non shell=true subcommand#3743
Merged
Remove quotes from format string passed to non shell=true subcommand#3743
Conversation
The lack of shell=true means this is just passed through literally, leading to the first line not starting with `author_name` but `'author name`, creating a bug. Signed-off-by: Adrian Edwards <adredwar@redhat.com>
MoralCode
added
the
high priority
Ulincsys
previously approved these changes
Feb 25, 2026
…pty string Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Contributor
Author
|
oh wow oops, looks like i pushed shortly after you approved haha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lack of shell=true means this is just passed through literally, leading to the first line not starting with
author_namebut'author_name, creating a bug because the commit parsing checks forstartswith('author_name')This PR fixes #3740
Notes for Reviewers
Signed commits