-
-
Notifications
You must be signed in to change notification settings - Fork 105
feat: Allow leaving a 'Contact Request' channel/group #7007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ok if "Leave" is renamed to "Send leave message" or smth like this. Otherwise it can leak other metadata, not only the public key.
Also it'd good to add the reasoning from the PR description to the commit message.
Why? Is there any protection against this in the core? |
No, only in the UIs IIRC. But for every user of chatmail-core that's not a UI (esp. bots), contact requests don't matter that much, anyway. |
I don't think we should rename this button; if we say that leaking this metadata is too big of a problem, then we shouldn't merge this PR. Not sure which metadata is leaked exactly; it's true that it wouldn't be nice if the avatar, bio, and display name were leaked. (BTW, this is not urgent. It has been impossible to leave contact request groups for ages, and channels are experimental, so, no need to rush this into 2.0; we can concentrate on other things first) |
b4661be
to
a8e39cb
Compare
a8e39cb
to
8ed2a22
Compare
There was an unmerged PR before that disables attaching profile data in group leave messages: #6813. Now we should do that at least for "Contact Request" groups here. But for me reviving that PR looks better, it's just a more simple approach. |
Re unmerged PR, I commented in that PR: #6813 (comment)
So this PR needs a multi-device test where Alice receives a group as a contact request, leaves it and receives leave message on a second device. Second device should not have the group and contact accepted and new group and direct requests should be received as a contact request. |
A long time ago, we decided that it should not be possible to send a 'Leave' message into a Contact Request group. The reasoning was: Maybe this comes from a spammer, and sending a 'Leave' message would let the spammer know that this account exists and is read by a human. Since channels are using the same code path for leaving, it's similarly not possible to leave a channel contact request.
However:
So, this PR proposes to change this logic, and to allow sending a 'Leave' message into contact request chats.
(FTR, discussion started at deltachat/deltachat-ios#2769 (comment))
Assuming we merge this PR, at some point we should adapt Android and Desktop to show this button for contact requests, but I'll write a list of things that should be adapted before making channels non-experimental, no need to do this right now.