refactor: receive_imf: Don't abort processing message on non-critical errors #7038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
force-pushed
the
iequidoo/receive_imf-skip-minor-errors
branch
from
cadbf3a to
6fa0342
Compare
|
Not sure this is an improvement. Ignoring errors adds more code paths where something goes wrong but we continue. Ignoring errors for "non-critical" operations like adding info messages, updating contact properties or other chats means we will not notice if they break unless we explicitly test that they work. |
|
Then we need to keep these errors in debug builds or even make them debug assertions. But in release builds we should make every effort not to miss messages. |
… errors Follow-up to f27d54f. Non-critical errors shouldn't lead to missing messages. But in debug builds, panic on such errors, otherwise we won't catch them w/o special tests.
iequidoo
force-pushed
the
iequidoo/receive_imf-skip-minor-errors
branch
from
6fa0342 to
0a005c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.