-
-
Notifications
You must be signed in to change notification settings - Fork 34
Adjust SSG pages & styles #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
can you agree on a code style already? css had 2-space tab so i applied it on html also reduces the size of resulting web page
horizontal padding should not be equal to vertical without border it looks cleaner, but feel free to ask to return it
Notes on the last commit:
|
As for 2e83186 Sorry, as I see it's the common design for all DeltaChat web pages, I'll return the button border and paddings, but please take a look at what i suggested, a button looks cleaner without a 1px-border (again, not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this. Truth be told, I'm rather sceptical with this PR. What you call a "mess" (please watch your tone while judging the work of others, it can demotivate and is therefore bad practice) is part of what any operator is supposed to change about their instance; some of them are not developers, don't know git, and might not have seen a merge conflict so far.
Aesthetic preferences, especially if they are only about code style and not about visible changes on the website, don't justify that others have to handle a merge conflict.
This means that a change to a .md or .html file needs to have a good reason, like legal issues with the current privacy policy or displaying a new config value on the info page.
The css changes are what I think could be worthwhile; the most notable difference is that the font sizes are a bit larger. The units are a bit more in the direction of web development best practice, indeed. Those we could probably merge, if someone else thinks it won't cause problems.
.link-centered { | ||
display: block; | ||
width: fit-content; | ||
margin: 0 auto; | ||
text-align: center; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks better on mobile but weird on desktop. I think I'd drop this suggestion.
maybe I'm holding it wrong, but I don't see much difference? Except this black line to the left which is a bit ugly: |
Yep, sorry, at that moment I was angry after editing web pages for my instance with different indentation (79c4e85) and even somehow non-ascii quotes in html (ade85c6) |
I glanced at opened PRs and seen no changes correspoding static pages, so I supposed that it's OK to adjust whitespace as there would be no merge conflicts |
Another codestyle thing that I've just reverted: single HTML tags. Sometimes they're written as |
No description provided.