feat: 调用音频url接口下载歌曲 - #43
Open
lrst6963 wants to merge 3 commits into
Open
Conversation
- 添加进度条管理器支持多任务并行显示 - 实现 MP3/FLAC 格式的 ID3v2 和 Vorbis 标签写入 - 增加专辑封面和歌词下载功能 - 优化 API 请求参数处理 - 更新依赖库版本
Owner
感谢代码贡献代码，最近有些繁忙，代码改动稍多些，抽时间看下。 |
chaunsin
reviewed
Mar 6, 2026
Owner
There was a problem hiding this comment.
建议，进度条处理采用本库引入的 github.com/cheggaaa/pb/v3 进行统一处理，便于代码维护。
chaunsin
reviewed
Mar 6, 2026
Owner
There was a problem hiding this comment.
github.com/go-flac/xxx 建议使用 v2版本库实现，减少包的体积，以及避免一些bug问题。
chaunsin
reviewed
Mar 6, 2026
chaunsin
left a comment
chaunsin
left a comment
Owner
There was a problem hiding this comment.
为了保证代码质量，以及可维护性，建议对代码做出调整，调整内容看请comment。
chaunsin
reviewed
Mar 6, 2026
| Ids: types.IntsString{songId}, | ||
| Level: types.Level(c.opts.Level), | ||
| EncodeType: "flac", | ||
| ImmerseType: "c51", |
Owner
There was a problem hiding this comment.
EncodeType和ImmerseType参数应该暴漏给上层调用，用户会存在下载其他歌曲音质情况，根据命令行参数。
chaunsin
reviewed
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
可绕过下载限制