fixes #14; fix compilation issues for latest nim release #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
changed the title
|
@cheatfate please merge, this is a big blocker |
|
@cheatfate could this be merged please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @cheatfate after this PR,
nimble testworks for httpbeast /cc @dom96before this PR, it was failing with:
note
supersedes part of #15 (i'm using TSa_Family instead of uint16, which seems better since that's how it's declared in code, eg:
lib/posix/posix_other.nim:390:17: sa_family*: TSa_Family), but other parts of #15 are still needed so maybe @treeform can update his PR (note: that PR has been waited on since october 2018...)