Fix autogen.sh with recent autoconf-2.71 and automake-1.16 #1271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherokee's Autoconf files are pretty outdated. Checking with autoscan results in several warnings. Fix autoscan warnings and correct deprecated syntax (e. g. AC_CONFIG_FILES, AC_OUTPUT). Fixes: #1249 Signed-off-by: Thomas Reim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a recent upgrade of a development system I have noticed the issues from #1249 and #1239. While both did not resolve the problems I encountered I was able to resolve the issues in the following way.
Starting from the work of @rdratlos I noticed that AM_INIT_AUTOMAKE was defined twice, this alone caused the direct breaking of autogen.sh with recent versions of automake and autoconf. Removing the second instance resolved the issue. While @neelpatel05 suggested to use AM_INIT_AUTOMAKE with "foreign subdir-objects" I have still not reproduced that using automake 1.16.5. Hence I have ignored this suggestion, but if someone can show how it breaks without it I'll obviously include it.
autoupdate-2.71 failed apply an update and terminated processing at an old AC_TRY_COMPILE code block of "Check of func and co.." I manually rewrote the AC_COMPILE_IFELSE. Applying autoupdate-2.71 to the rest of the m4 files in the repository allowed me to clean up all the remaining warnings.