[core] Add Property[String] assertion message - #5459
Merged
seldridge merged 4 commits intoAug 12, 2026
Merged
Conversation
Add an alternative property assertion API which takes a `Property[String]` message. This builds towards allowing for string interpolation in property assertion messages. Due to the limited availability of property operations, this is relatively limited in power and very verbose. More operations (e.g., number to string formatting) and better ergonomics are planned. Assisted-by: pi.dev:gpt-5.6-luna Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Fix an issue where infix `++` did not work for `Property[String]` because this would fallback to the list version (which also has the same infix operator). Assisted-by: pi.dev:gpt-5.6-luna Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
seldridge
force-pushed
the
dev/seldridge/property-assert-property-message
branch
from
August 12, 2026 01:38
4634e1f to
5573bcc
Compare
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
seldridge
marked this pull request as ready for review
August 12, 2026 17:24
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 13, 2026
Add an alternative property assertion API which takes a `Property[String]` message. This builds towards allowing for string interpolation in property assertion messages. Due to the limited availability of property operations, this is relatively limited in power and very verbose. More operations (e.g., number to string formatting) and better ergonomics are planned. Fix an issue where infix `++` did not work for `Property[String]` because this would fallback to the list version (which also has the same infix operator). Assisted-by: pi.dev:gpt-5.6-luna Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
seldridge
added a commit
that referenced
this pull request
Aug 14, 2026
Add an alternative property assertion API which takes a `Property[String]` message. This builds towards allowing for string interpolation in property assertion messages. Due to the limited availability of property operations, this is relatively limited in power and very verbose. More operations (e.g., number to string formatting) and better ergonomics are planned. Fix an issue where infix `++` did not work for `Property[String]` because this would fallback to the list version (which also has the same infix operator). Assisted-by: pi.dev:gpt-5.6-luna Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an alternative property assertion API which takes a
Property[String]message. This builds towards allowing for string interpolation in
property assertion messages. Due to the limited availability of property
operations, this is relatively limited in power and very verbose. More
operations (e.g., number to string formatting) and better ergonomics are
planned.
Assisted-by: pi.dev:gpt-5.6-luna
Release Notes
to a Scala string) to allow for more dynamic assertion messages. The existing
Scala string assert message API is preserved.