Skip to content

Pr comments demo #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chmccreery wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Pr comments demo #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36794b3
add vulns
chmccreery Feb 18, 2022
70adf74
hackathon demos
chmccreery Feb 18, 2022
ad1fdb1
update PR number
chmccreery Feb 18, 2022
e2217d8
Secret Semgrep
chmccreery Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cron-test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,8 @@
5 == 5
6 == 6
print('hello')

myvar = 0
myvar_max = 3

if (myvar == myvar):
print('var reached maximum')
2 changes: 1 addition & 1 deletion foo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"pull_request":{"number":18, "base":{"sha":"main"}}}
{"pull_request":{"number":21, "base":{"sha":"main"}}}
1 change: 1 addition & 0 deletions server/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from flask import jsonify
from flask import request
from flask import Response
import xml
Copy link

@semgrep-app-local-dev semgrep-app-local-dev bot Feb 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found use of the native Python XML libraries, which is vulnerable to XML external entity (XXE) attacks and can lead to discolsure of confidential data. The Python documentation recommends the 'defusedxml' library instead.

Suggested change
import xml
import defusedxml
🔴 Fix or ignore this finding to merge your pull request.
🙈 From python.lang.security.use-defused-xml.use-defused-xml.

from werkzeug.exceptions import (
BadRequest,
NotFound,
Expand Down