Skip to content
This repository was archived by the owner on Oct 28, 2025. It is now read-only.

(#1) Initialize choco-playwright#2

Merged
corbob merged 5 commits intomainfrom
init
May 13, 2025
Merged

(#1) Initialize choco-playwright#2
corbob merged 5 commits intomainfrom
init

Conversation

@st3phhays
Copy link
Collaborator

@st3phhays st3phhays commented May 7, 2025

Description Of Changes

This is the initial PR to get all the "things" needed for a new choco-playwright package to be used and consumed by other projects.

Motivation and Context

We have several Playwright functions and dependencies that can be reused across projects to remove duplication.

Testing

  1. Run yarn.
  2. Run yarn choco-theme.
  3. Run yarn eslint. This should pass. You'll know because it will not report any errors or warnings.
  4. Run yarn audit. This should pass.

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

This commit sets up Yarn 4 in the project as well
as some configuration files needed for various
configurations.
@st3phhays st3phhays force-pushed the init branch 4 times, most recently from bcca4d7 to cfedcb3 Compare May 8, 2025 18:01
@st3phhays
Copy link
Collaborator Author

A new version of choco-theme must be released before this PR can be merged.

@st3phhays st3phhays requested a review from vexx32 May 8, 2025 20:01
@st3phhays st3phhays self-assigned this May 8, 2025
@st3phhays st3phhays marked this pull request as ready for review May 9, 2025 19:29
st3phhays added 4 commits May 13, 2025 12:05
This commit includes all the initial files needed
for choco-playwright. This includes tests, assertions,
functions, and data files.
This installs eslint and applies it to files. A few files have been
updated due to the eslint config rules. This also adds choco-theme as a
devDependency so that eslint packages can be consumed by it, and so that
choco-theme functions or additional packages can be used inside of tests.

By running the choco-theme command, the eslint.config.mjs file will be
coppied over, ready for use.
This adds GitHub workflows for auditing dependencies, running eslint,
and also publishing the package to npm.
@corbob corbob merged commit 79ceda5 into main May 13, 2025
2 checks passed
@corbob
Copy link
Contributor

corbob commented May 13, 2025

This looks really good. Thanks for getting it added @st3phhays 👍

Copy link

@MrG9090 MrG9090 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@st3phhays st3phhays deleted the init branch August 21, 2025 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants