(#1716) - Use chocolateyPackageName as default parameter for packageName#1974
Open
cowmanjoe wants to merge 2 commits intochocolatey:masterfrom
Open
(#1716) - Use chocolateyPackageName as default parameter for packageName#1974cowmanjoe wants to merge 2 commits intochocolatey:masterfrom
cowmanjoe wants to merge 2 commits intochocolatey:masterfrom
Conversation
Set default value of packageName to $env:chocolateyPackageName for Install-ChocolateyZipPackage and Get-ChocolateyUnzip. This is usually the value used as default in install scripts, so this can reduce the number of necessary parameters specified.
cowmanjoe
changed the title
There were six more scripts using a packageName variable which should have access to the chocolateyPackageName environment variable. This should be used the default value for the packageName for the scripts so that we can reduce the number of necessary arguments.
Contributor
Author
|
Closes #1716 |
|
|
gep13
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets the default value of
$packageNameto$env:chocolateyPackageNameforInstall-ChocolateyZipPackageandGet-ChocolateyUnzip. This is usually the value used as default in install scripts, so this can reduce the number of necessary parameters specified.I followed what was stated in the ticket, but thought there might be some more scripts where this could be useful, such as
Install-ChocolateyPackage. Should I add the defaults there as well?Closes #1716