fix+feat+docs: PR batch #46 #34 #47 — build.rs fix, Nix flake, Swagger UI#52
Merged
Conversation
…l catalog Add reproducible Nix packaging for larql: - flake.nix orchestrator importing modular files from nix/ - package.nix: Rust derivation with cargoHash, system protoc via patch - shell.nix: dev shell with Rust tools, Python/maturin, debuggers - container.nix: OCI images for larql-server and larql CLI (Linux) - models.nix: 8-model HuggingFace catalog (SmolLM2, Qwen, TinyLlama, StableLM, Phi-3.5, Gemma 4 E2B/E4B) fetched as fixed-output derivations - demo.nix: per-model walk demos and interactive REPL targets - Patches: remove protobuf-src (use nixpkgs protoc), disable default metal feature (macOS-only), add cfg guard to bench_cmd.rs - README.md: install guide, remote usage from GitHub, model docs - Commit Cargo.lock (required by buildRustPackage) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…mple initializers The Virtual Experts merge (PR #45) left `main` unable to build: 1. `crates/larql-vindex/src/extract/build.rs` was deleted but `extract/mod.rs` still declares `pub mod build;` and re-exports `build_vindex` / `build_vindex_resume`, which are still called from `larql-cli`, `larql-lql`, the vindex tests, and the `demo_features` example. The roadmap (vindex M8) plans to split this file into `build/{mod,...}.rs`, but that refactor was never finished. Restore the file from `d3a8bc6^` so the workspace compiles again; the planned split can land separately. 2. New required fields had been added to several public structs but a number of test fixtures and examples were not updated, so `cargo build --features metal` and `cargo test --workspace` failed with E0063 / E0308: - `FullPipelineLayer.ffn_is_remote` — added to 6 `larql-compute` examples (`compare_decode`, `compare_formats`, `compare_ollama`, `compare_pipeline`, `demo_architecture`, `diag_decode_pipeline`). - `LoadVindexOptions.moe_remote` — added to `bench_expert_server` and `openai_demo` examples. - `LoadedModel.{unit_filter, moe_remote}` plus the `metal-experts`-conditional `metal_backend` / `moe_scratches` / `metal_ffn_layer_bufs` fields, and the `weights` field's new `OnceLock<RwLock<ModelWeights>>` wrapper — fixed in `tests/common/mod.rs`, `tests/test_expert_endpoint.rs`, `tests/test_http_full_routes.rs`, `tests/test_unit_band_utils.rs`, `tests/test_unit_state.rs`. - `VindexConfig.{fp4, ffn_layout}` and `ModelWeights.skipped_tensors` in `tests/test_expert_endpoint.rs`. - `MoeLayerWeights.expert_data_format` plus per-expert byte-slice layout (`Vec<&[u8]>` instead of a single `&[u8]`) in the same test's `local_output` helper. Result: workspace builds clean with `--features metal`, and 3,481 tests run (the remaining failures are runtime numerical-correctness issues in Metal kernels — unrelated to this commit, and the reason this branch exists). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
chrishayuk
added a commit
that referenced
this pull request
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(build): restoreextract/build.rs(deem0n) — uses named constants fromstage_labels/filenamesinstead of hardcoded strings; alignsffn_is_remote: falsein examples/testsfeat(nix): Nix flake for reproducible builds + containers + demos (randomizedcoder); also removesCargo.lockfrom.gitignore(correct for a binary workspace)docs(larql-server): Swagger UI at/swagger-uiand/v1/openapi.jsonviautoipa(priyanshu891); opt-out with--no-docsNot included
Test plan
cargo check --workspaceclean on macOS