NuGet Cleaner V1 #2
Conversation
This reverts commit 94dde62.
| } | ||
| } | ||
|
|
||
| public static int CheckDisableLastAccess() |
There was a problem hiding this comment.
This method will only work on Windows, making the entire tool Windows only. If that's the intent, ok, but nothing in the package description makes that obvious, only if they look at the readme they might guess. So I can imagine people on Mac or Linux trying to install and use the tool.
You could work cross platform if you did something similar to the following:
- create an empty file (possibly need to contain at least 1 byte)
- use
File.SetLastAccessFileto some time in the past (possibly need to read the value to make sure it's correct) - read the file
- check the last access file, to make sure it's newer than the value you set in 2
- delete the file
|
|
||
| int Days = options.Days; | ||
|
|
||
| if (options.DryRun) |
There was a problem hiding this comment.
SearchAndPrint and SearchAndDestory are mostly the same, just the body of the inner most loop is different. I'd put that difference in individual methods and have a single Search method that accepts and calls an Action<string>. That reduces duplicate code.
| @@ -0,0 +1,26 @@ | |||
| # Your spec's journey | |||
| * Create a new wiki page using the spec template below, to jot your thoughts down. | |||
| * Create an [issue](https://github.com/NuGet/Home/issues) to track the feature or link an existing issue to the new wiki page. Engage the community on the feature. Feel free to tweet it from the @NuGet handle or ask the PM to tweet it out. | |||
There was a problem hiding this comment.
This repo is not in the NuGet org, so I don't think it's appropriate to direct customers to file issues in NuGet/Home.
| public static void Main(string[] args) | ||
| { | ||
| var osNameAndVersion = System.Runtime.InteropServices.RuntimeInformation.OSDescription; | ||
| if (!osNameAndVersion.Contains("Windows")) |
There was a problem hiding this comment.
You should be able to do a more concrete "is windows" check with this:
https://docs.microsoft.com/en-us/dotnet/api/system.runtime.interopservices.runtimeinformation.isosplatform?view=netframework-4.8
There was a problem hiding this comment.
Consider:
private static IsWindows(){
if (System.Runtime.InteropServices.RuntimeInformation.IsOSPlatform(System.Runtime.InteropServices.OSPlatform.Windows))
{
return true;
}
return false;
}| var osNameAndVersion = System.Runtime.InteropServices.RuntimeInformation.OSDescription; | ||
| if (!osNameAndVersion.Contains("Windows")) | ||
| { | ||
| Console.WriteLine("This tool is currently only available for Windows, sorry for the inconvenience!\n"); |
There was a problem hiding this comment.
Explicit line endings are a bit strange. I would recommend either Environment.NewLine or another Console.WriteLine.
| } | ||
|
|
||
| var settings = Settings.LoadDefaultSettings("."); | ||
| var gpfPath = SettingsUtility.GetGlobalPackagesFolder(settings); |
|
|
||
| public static int CheckDisableLastAccess() | ||
| { | ||
| System.Diagnostics.Process process = new System.Diagnostics.Process(); |
| return setting; | ||
| } | ||
|
|
||
| public static void SearchAndDestroy(string Path, int Days) |
| } | ||
| } | ||
|
|
||
| public static void RecursiveDelete(string dir) |
There was a problem hiding this comment.
| `nugetcleaner` is available as a .NET Core Global Tool: | ||
|
|
||
| ```bash | ||
| dotnet tool install --global NuGetCleaner --version 1.0.7 |
| <Description>Cleans up Global Package Folder by deleting directories unaccessed for a time greater than a specified threshold.</Description> | ||
| <PackageProjectUrl>https://github.com/chgill-MSFT/NuGetCleaner</PackageProjectUrl> | ||
| <RepositoryUrl>https://github.com/chgill-MSFT/NuGetCleaner</RepositoryUrl> | ||
| <GeneratePackageOnBuild>true</GeneratePackageOnBuild> |
There was a problem hiding this comment.
The .nupkg and .snupkg files should probably not be checked in to the repo.
| Any .NET developer that installs packages (i.e. every .NET developer). | ||
|
|
||
| ## Evidence | ||
| At the moment, my evidence is that Karan says he has seen complaints from customers about this issue. Exact evidence TBD. |
There was a problem hiding this comment.
Who is Karan? :) maybe mention his alias
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>netcoreapp2.1</TargetFramework> |
NuGetCleaner is meant to "clean up" the global package folder by deleting old or no longer relevant packages. The user specifies a max number of days since package "last access" (used in build) and anything outside of the range is deleted.
This PR is a way of letting people make comments on my code. The goal for me to have experienced developers give me feedback on everything from coding style and structure to choice of APIs and algorithms. I would like to ensure I become familiar with strong coding standards and habits for future projects. Any and all feedback is highly appreciated!
I imagine Program.cs and Option.cs should the subject of the most discussion since they contain my code, but if you find anything you wish to comment on on any of other files, feel free to do so!