Skip building src on non-linux targets #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows compilation for testing to complete on non-linux targets. This is useful when integrating this crate into larger projects, where we still want to test locally before pushing to CI (on a macos host for instance). Signed-off-by: Joe Grund <[email protected]>
jgrund
force-pushed
the
jgrund/skip-building
branch
from
9e44a73 to
a940877
Compare
|
Hi, the test doesn't really match the commit name. If you want to skip building on non-Linux targets the the test should be for !linux rather than Mac OS. I realise it's a sematic difference but it's important to understand what's meant here. of course, I now need to check if it runs on FreeBSD :) |
|
OK, it runs fine on FreeBSD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows compilation for testing to complete on non-linux targets.
This is useful when integrating this crate into larger projects, where we still want to test locally before pushing to CI (on a macos host for instance).
Signed-off-by: Joe Grund [email protected]