Repository navigation
fix(playwright): restore support for projects[].use.viewport - #444
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 647d113 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
AriPerkkio
force-pushed
the
fix/playwright-projects-viewports
branch
2 times, most recently
from
August 28, 2026 12:14
600493b to
c60809d
Compare
JReinhold
approved these changes
Sep 24, 2026
AriPerkkio
force-pushed
the
fix/playwright-projects-viewports
branch
from
September 25, 2026 07:33
c60809d to
647d113
Compare
AriPerkkio
marked this pull request as ready for review
September 25, 2026 07:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
What Changed
When user defines multiple Playwright projects that run same test files, each of them write the same
test-result/chromatic-archives/<name>.stories.jsonfile. They are overriding each others results. This is known bug that was never fixed in #258.Before #318 it was actually possible to support viewports from multiple projects. After the test run when
(build-)archive-storybookis called, thetest-result/chromatic-archives/archive/was read and each*.stories.json'sparameters.viewportwas rewritten again. This works only forviewports- other project level options (likecolorScheme) are not respected. They work only per-snapshot.How to test
packages/playwrightnow runs multiple projects so this repository's Chromatic project should show multiple viewports