Merge 0.4.x #1502
Merged
Merge 0.4.x #1502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuchsia is doing an audit of chrono 0.4.34, and we noticed an unncessary unsafe of `Send` for `DateTime`. While it's valid since `Tz::Offset` is `Send`, and `NaiveDateTime` only has `u32` fields, there's a potential hazard if `NaiveDateTime` ever grows unsendable fields (unlikely as that is). This (and the `Copy` impl) were added 9 years ago to fix #25, which stemmed from early versions of associate traits not working properly with auto-traits. This has since been fixed, and is no longer necessary with the MSRV 1.61.0.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.5.x #1502 +/- ##
=======================================
Coverage 94.04% 94.04%
=======================================
Files 37 37
Lines 17033 17033
=======================================
Hits 16019 16019
Misses 1014 1014 ☔ View full report in Codecov by Sentry. |
|
New policy: feel free to merge these merge PRs without review, I'm not going to be able to find botched merge conflicts (better than the test suite/CI) will anyway so I just skim them, no need to block on me. (Unless there's a tricky manual conflict resolution that you specifically want to call out/get reviewed, of course!) |
djc
approved these changes
Mar 11, 2024
|
Very good, those are indeed not very reviewable 😄. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally I'd wait until we have more than just a handful of PR's merged to main, but this allows @Zomtir to rebase on #1500.