link: allow '-' in tracepoint group names #1855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmat11
reviewed
Aug 20, 2025
|
I think this test will fail https://github.com/cilium/ebpf/blob/main/internal/tracefs/perf_event_test.go#L34 |
AryanBakliwal
force-pushed
the
fix-tracegroup-hyphen
branch
from
37d2421 to
7f392cc
Compare
Signed-off-by: Aryan Bakliwal <[email protected]>
ti-mo
force-pushed
the
fix-tracegroup-hyphen
branch
from
7f392cc to
ddbc20c
Compare
ti-mo
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where attaching eBPF programs to tracepoints with group names containing
-(e.g.,xhci-hcd) would fail with:The root cause is that the
validIdentifierfunction intracefsrejected-characters, even though they are valid in tracepoint group names.Fixes #1854