feat: add ITokenMessenger and ITokenMessengerV2 interfaces#103
Open
dolepee wants to merge 1 commit intocirclefin:masterfrom
Open
feat: add ITokenMessenger and ITokenMessengerV2 interfaces#103dolepee wants to merge 1 commit intocirclefin:masterfrom
dolepee wants to merge 1 commit intocirclefin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
ITokenMessengerandITokenMessengerV2Solidity interfaces tosrc/interfaces/andsrc/interfaces/v2/, respectively.Motivation
The
src/interfaces/directory already provides interfaces forITokenMinter,IMessageTransmitter,IMessageHandler, and other core contracts, butTokenMessengerandTokenMessengerV2lack corresponding interfaces. This makes it harder for external protocols and integrators to interact with CCTP in a type-safe, composable way without importing the full concrete implementations.Changes
src/interfaces/ITokenMessenger.sol— Interface covering all external functions ofTokenMessenger:depositForBurn,depositForBurnWithCaller,replaceDepositForBurn,handleReceiveMessage, and admin functions (addRemoteTokenMessenger,removeRemoteTokenMessenger,addLocalMinter,removeLocalMinter).src/interfaces/v2/ITokenMessengerV2.sol— Interface covering all external functions ofTokenMessengerV2andBaseTokenMessenger:depositForBurn,depositForBurnWithHook,handleReceiveFinalizedMessage,handleReceiveUnfinalizedMessage,getMinFeeAmount, fee/admin functions, andinitializedVersion.Both files follow the existing license header, pragma, and documentation style of neighboring interfaces.
Closes: #63