fix: job transition after failed recovery #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raresgaia123
force-pushed
the
failing_stop
branch
from
1ac6439 to
981a4cf
Compare
myungjin
approved these changes
Jan 16, 2026
If some worker can't be recovered, logic is to remove the pipeline of these workers and check if the job is still able to run. In the case of incomplete data loop after pipeline removal, the job will transition to Failing state. Failing state will then wait for all workers to have certain status before transitioning to Failed state. The bug was in the way we updated the worker status in job context. _reconcile_wrk_status was using workers from wrong source - class attribute 'self._new_cfg' instead of 'new_cfg' received as argument.
raresgaia123
force-pushed
the
failing_stop
branch
from
981a4cf to
390a581
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If some worker can't be recovered, logic is to remove the pipeline of these workers and check if the job is still able to run. In the case of incomplete data loop after pipeline removal, the job will transition to Failing state. Failing state will then wait for all workers to have certain status before transitioning to Failed state. The bug was in the way we updated the worker status in job context. _reconcile_wrk_status was using workers from wrong source - class attribute 'self._new_cfg' instead of 'new_cfg' received as argument.
Type of Change
Checklist