fix: incorrect planner state after job completion #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raresgaia123
changed the title
After a job is executed, job context needs to do proper cleanup. In this bug, previous job execution did a scale_in, therefore, demand_data reflected that in its scale_out attribute, set to false. That means that if we want to run the same job again, planner would try to do a scale_in resulting in errors. Bug was fixed by properly resetting demand_data attribute from the job context.
raresgaia123
force-pushed
the
fix_planner
branch
from
f1f7bed to
d7762a6
Compare
myungjin
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After a job is executed, job context needs to do proper cleanup. In this bug, previous job execution did a scale_in, therefore, demand_data reflected that in its scale_out attribute, set to false. That means that if we want to run the same job again, planner would try to do a scale_in resulting in errors. Bug was fixed by properly resetting demand_data attribute from the job context.
Type of Change
Checklist