chore(deps): bump node from 22-bookworm-slim to 26-bookworm-slim in /docker in the docker group across 1 directory#557
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d48892494
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # Keep the Docker base on Node 22 because the official Node 24/25 slim images | ||
| # no longer publish linux/arm/v7 manifests, which breaks our armv7 Docker jobs. | ||
| FROM node:22-bookworm-slim AS builder | ||
| FROM node:26-bookworm-slim AS builder |
There was a problem hiding this comment.
Keep an armv7-capable Node base image
When the existing CI/release Docker matrix builds linux/arm/v7 (.github/workflows/ci.yml and release.yml both still include arch: armv7), Buildx has to resolve this FROM image for arm/v7 before any Dockerfile logic runs. The file comment and the checked-in guard test (scripts/dev/docker.workflow.test.ts, uses an armv7-capable node base image) document that the Node 22 slim base is intentional for those armv7 jobs, and this change makes that test fail while leaving the armv7 publish path enabled.
Useful? React with 👍 / 👎.
4d48892 to
1b354b3
Compare
Bumps the docker group with 1 update in the /docker directory: node. Updates `node` from 22-bookworm-slim to 26-bookworm-slim --- updated-dependencies: - dependency-name: node dependency-version: 26-bookworm-slim dependency-type: direct:production dependency-group: docker ... Signed-off-by: dependabot[bot] <support@github.com>
1b354b3 to
921dc47
Compare
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Bumps the docker group with 1 update in the /docker directory: node.
Updates
nodefrom 22-bookworm-slim to 26-bookworm-slim