Feature/issue 664/limit for maximum and minumum timelock #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce maximum and minimum allowed fidelity timelocks in blocks Ensuring MakerConfig::new() returns a valid configuration
Moves fidelity verification logic out of utils and into wallet/fidelity, allowing fidelity_redeemscript to remain private and enforcing module boundaries.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #667 +/- ##
==========================================
+ Coverage 68.87% 77.90% +9.03%
==========================================
Files 35 49 +14
Lines 4932 14495 +9563
==========================================
+ Hits 3397 11293 +7896
- Misses 1535 3202 +1667 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #664
Summary
Validates fidelity timelock constraints at configuration time to prevent
makers from starting with an invalid fidelity bond setup.
Changes
MakerConfig::new()constructionfidelity_redeemscriptprivate within the fidelity modulewallet/fidelity.rs