Skip to content

Conversation

@Cyrix126
Copy link

No description provided.

@NeoZ666
Copy link
Collaborator

NeoZ666 commented Jul 17, 2025

Currently module is neither that complex, nor are it's outputs non-deterministic (barring srd). This can be added later on with more complex algorithms.

@Cyrix126
Copy link
Author

Cyrix126 commented Jul 18, 2025

so far, panics where encountered when you have an addition operation that are not checked

example:

options.target_value + options.min_change_value + base_fees.max(options.min_absolute_fee);

It can happen if values given to options or inputs are enormous and result in overflowing u64 when making operations with them. Checking the result and returning an error like AbnormalHighAmount would be safer.

Note that in release mode, the result of the overflowing would be 0, but a returned error would still be preferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants