Per-entity search #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than combining all fields from different entities into one big schema, pass the separate schemas namespaced by entity type to providers so they can decide how to handle them. For now the Solr and ES providers haven't been modified (i.e. they still use a single core / index for all entities) but we probably want to change that in the future (although it may make cross-entity queries difficult). To register a new entity to get index plugins can use the `register_search_schema()` function which will be present in the toolkit.
This will allow providers to target the right core/index, and CKAN to use different search query schemas for different entities.
The ISearchEntity encapsulates all logic related to the indexing and querying of a particular entity type, either core ones like datasets or orgs or custom ones defined by the user. It contains methods to return the search schema to use for this entity (i.e. indexed fields) and a search query schema to add additional query params that are entity-specific. In addition contains methods to retrieve the entities to index, and a list of all the entity ids. This includes a first draft of the ISearchEntity plugin for datasets, still not hooked to the rest of the logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
searchaction only works against a providedentity_type, not across all entitiesISearchEntityinterface, used to encapsulate all search logic of a particular entity like dataset, org, custom, etc: schema, search query schema, transforming search data, getting ids...