Skip to content

Conversation

@smotornyuk
Copy link
Member

Compatibility with the new SQLAlchemy version tested against this PR.

@duttonw
Copy link
Collaborator

duttonw commented Sep 10, 2024

Looks like setup tools for 2.9 has started to fail unrelated to your changes.

  /usr/lib/python3.9/site-packages/setuptools/_distutils/dist.py:261: UserWarning: Unknown distribution option: 'tests_require'

@ThrawnCA
Copy link
Collaborator

Looks like setup tools for 2.9 has started to fail unrelated to your changes.

We can fix that, but I'll note that with the release of CKAN 2.11, 2.9 is no longer officially supported: https://ckan.org/blog/the-new-ckan-211-release-is-now-available

@ThrawnCA
Copy link
Collaborator

Looks like 2.9 isn't compatible with the newer SQLAlchemy. We should probably make version-specific requirements files.

@duttonw
Copy link
Collaborator

duttonw commented Oct 15, 2024

I've cut a release today for 1.2.0 which is compatible for 2.9 ~ 2.11.

I'm ok with dropping 2.9 support via this PR, I've updated the doc's and cicd pipeline accordingly.

I'd like to pull in the last pieces of work from the qld-gov-au fork prior to this being included for one last 1.x.x release.

As this is major breaking change, it should bump to 2.0.0 on this being merged into master/released.

@duttonw duttonw force-pushed the sqlalchemy2 branch 2 times, most recently from 627c33c to 24ef661 Compare November 21, 2024 04:48
@duttonw duttonw requested a review from ThrawnCA November 21, 2024 04:50
smotornyuk and others added 2 commits December 10, 2024 09:28
BREAKING CHANGE: SQLAlchemy v2 is not supported in CKAN 2.9.x. CKAN 2.9.x support dropped
@duttonw duttonw merged commit a771128 into master Dec 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants