Skip to content

Conversation

Marwes
Copy link
Contributor

@Marwes Marwes commented Jul 7, 2017

All the other features are either irrelevant, for nightly or already included by default so this should build with all features.

https://github.com/onur/docs.rs/pull/73

Fixes #911


This change is Reviewable

All the other features are either irrelevant, for nightly or already included by default so this should build with all features.

https://github.com/onur/docs.rs/pull/73

Fixes clap-rs#911
@mention-bot
Copy link

@Marwes, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbknapp to be a potential reviewer.

@coveralls
Copy link

coveralls commented Jul 7, 2017

Coverage Status

Coverage remained the same at 91.926% when pulling 28fddd1 on Marwes:patch-2 into e27a6ff on kbknapp:master.

@kbknapp
Copy link
Member

kbknapp commented Jul 21, 2017

@homu r+ thanks! Sorry for the delay, I've been doing a lot of traveling.

@kbknapp kbknapp merged commit 4030c55 into clap-rs:master Jul 21, 2017
@Marwes Marwes deleted the patch-2 branch July 21, 2017 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants