allow GA code to come straight from settings.py #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, which is used in preference to the value set for the site
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are uses cases (e.g. mine) where we may not want to have a full-blown sites framework, or configurability from admin, but simply want to use an analytics code set in
settings.py. This change allows that, preferring to usesettings.GOOGLE_ANALYTICS_CODEwhen the code is not explicitly provided for the admin tag. When this isn't set, it falls back to the standard attempt to get the value from sites (not sure if this would be better the other way around, but this way works for me)