Make leak detector robust against leaks from preceding tests #764
+19
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[A CI test run](https://app.circleci.com/pipelines/github/clj-commons/aleph/769/workflows/1be2f5bc-92a9-4768-aa93-845365476aaf/jobs/753/parallel-runs/0/steps/0-107) recently failed with this error coming from the resource leak detector: ERROR in (test-basic-auth-value-encoding) (core.clj:2362) expected: (= "Basic Og==" (middleware/basic-auth-value nil)) actual: java.lang.ClassCastException: clojure.lang.Var$Unbound cannot be cast to clojure.lang.IAtom at clojure.core$swap_BANG_.invokeStatic (core.clj:2362) clojure.core$swap_BANG_.invoke (core.clj:2362) aleph.resource_leak_detector$_reportTracedLeak.invokeStatic (resource_leak_detector.clj:138) aleph.resource_leak_detector$_reportTracedLeak.invoke (resource_leak_detector.clj:137) aleph.resource_leak_detector.reportTracedLeak (:-1) However, the test namespace in question isn't even instrumented for leak detection (i.e. there is no `aleph.resource-leak-detector/instrument-tests!` call at its bottom). Immediately before this error, there is another one, though: ERROR in (test-shutdown-timeout-1) (resource_leak_detector.clj:103) Uncaught exception, not in assertion. expected: nil actual: java.lang.RuntimeException: Gave up awaiting leak probe. Try increasing `aleph.resource-leak-detector/max-probe-gc-runs`. This indicates that there was still a pending leak detection probe which was then (attempted to be) reported in the context of the following test. To prevent such red herrings in the future, we now gracefully report such leaked leaks.
DerGuteMoritz
deleted the
make-leak-detector-robust-against-async-leaks-beyond-test-scope
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A CI test run recently failed with this error coming from the resource leak detector:
However, the test namespace in question isn't even instrumented for leak detection (i.e. there is no
aleph.resource-leak-detector/instrument-tests!call at its bottom). Immediately before this error, there is another one, though:This indicates that there was still a pending leak detection probe which was then (attempted to be) reported in the context of the following test. To prevent such red herrings in the future, we now gracefully report such leaked leaks.