Skip to content

Conversation

borkdude
Copy link
Contributor

@borkdude borkdude commented Dec 6, 2024

@borkdude borkdude marked this pull request as draft December 6, 2024 11:11
@borkdude borkdude marked this pull request as ready for review March 10, 2025 20:00
@borkdude
Copy link
Contributor Author

I also tested this branch locally with babashka and everything seems to work, which confirms that this upgrade also works with GraalVM native-image:

$ script/run_lib_tests hickory.test.core hickory.test.convert    hickory.test.hiccup-utils   hickory.test.render   hickory.test.select  hickory.test.zip
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

Testing hickory.test.core

Ran 4 tests containing 10 assertions.
0 failures, 0 errors.

Testing hickory.test.convert

Ran 3 tests containing 12 assertions.
0 failures, 0 errors.

Testing hickory.test.hiccup-utils

Ran 8 tests containing 50 assertions.
0 failures, 0 errors.

Testing hickory.test.render

Ran 5 tests containing 19 assertions.
0 failures, 0 errors.

Testing hickory.test.select

Ran 34 tests containing 121 assertions.
0 failures, 0 errors.

Testing hickory.test.zip

Ran 2 tests containing 10 assertions.
0 failures, 0 errors.
{:test 56, :pass 222, :fail 0, :error 0}

@slipset slipset merged commit 9385b67 into master Mar 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants