route53-migrate-zone: Support multiple record types per record name at destination #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current code indexed on record.name, alone, but multiple types may exist for the same record. For example: MX, TXT, A frequently exist at the zone apex. - Add support for AAAA, PTR, SRV records - Change destination_zone_existing_resource_record_dict to use a two-level dictionary of [record.name][record.type] - Update diff_record to use passed variables instead of globals - Change logging for duplicate, but different, record to WARNING and print source and dest records This code can likely be simplifed by changing the record type whitelist to a blacklist of just SOA and NS records.
joegross
changed the title
joegross
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code indexed destination record on record.name, alone, but multiple types may exist
for the same record. For example: MX, TXT, A frequently exist at the zone apex.
dictionary of [record.name][record.type]
print source and dest records
This code can likely be simplifed by changing the record type whitelist
to a blacklist of just SOA and NS records.