Remove cloud_etc_hosts module when DHCP is disabled#418
Open
Cristi1324 wants to merge 1 commit into
Open
Conversation
Cristi1324
force-pushed
the
add-disable-manage-hosts
branch
2 times, most recently
from
ec944cb to
e0db0f7
Compare
Cristi1324
force-pushed
the
add-disable-manage-hosts
branch
from
e0db0f7 to
5a43f85
Compare
Dany9966
requested changes
May 13, 2026
| def _reset_cloud_init_run(self): | ||
| self._exec_cmd_chroot("cloud-init clean --logs") | ||
|
|
||
| def _disable_cloud_manage_etc_hosts(self): |
Contributor
There was a problem hiding this comment.
I think you should also add the list of cloud modules without the update_etc_hosts into cloud_cfg_mods instead of directly modifying the main file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.