integration: Move mock patches to class setUp#424
Merged
petrutlucian94 merged 1 commit intocloudbase:masterfrom May 8, 2026
Merged
integration: Move mock patches to class setUp#424petrutlucian94 merged 1 commit intocloudbase:masterfrom
petrutlucian94 merged 1 commit intocloudbase:masterfrom
Conversation
oslotest's base class may add mock.patch.stopall to the cleanup (`super().addCleanup(mock.patch.stopall)`), which means that the patches we have made in the harness will be undone when the second test runs. This may mean that `psutil.Process.send_signal` becomes unpatched, and SIGINT will be sent to the test runners, typically on cancelation tests.
claudiubelu
force-pushed
the
patch-integration
branch
from
ce186d0 to
6b94aad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oslotest's base class may addmock.patch.stopallto the cleanup (super().addCleanup(mock.patch.stopall)), which means that the patches we have made in the harness will be undone when the second test runs.This may mean that
psutil.Process.send_signalbecomes unpatched, and SIGINT will be sent to the test runners, typically on cancelation tests.