Skip to content

Fix wrong assert if padding is disabled #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Fix wrong assert if padding is disabled #21

wants to merge 25 commits into from
+75 −6

Conversation

simc
Copy link

@simc simc commented Mar 19, 2021

No description provided.

@inikulin inikulin requested review from vkrasnov and wbl March 26, 2021 13:50
@inikulin
Copy link
Collaborator

@leisim Could you give more context for the issue that this one fixes, please? Regression test would be useful too

@simc
Copy link
Author

simc commented Mar 26, 2021

@inikulin
This assert assert!(output.len() >= input.len() + block_size); requires the output size to be greater than the input size to make sure there is enough space for padding.
If no padding is used (not necessary if the input size is a multiple of the cipher block size) the output of the encryption has the exact same size as the input.

I'll add a regression test 👍

nox and others added 22 commits April 6, 2021 10:04
@nox
Provide access to inner I/O error during handshake
dd04ec0
@nox
Allow uppercase acronyms
e13112e
@inikulin
Merge pull request #25 from nox/expose-io-error
3838b11 
Provide access to inner I/O error during handshake
@nox
Bump boring-sys to 1.1.1, tokio-boring to 2.1.2
f4b8870
@inikulin
Merge pull request #26 from nox/bump
c4e1966 
Bump boring-sys to 1.1.1, tokio-boring to 2.1.2
@nox
Allow returning the server name from the early callback
6baba64
@nox
Allow retrieving the version string from early callback
d147f15
@inikulin
Merge pull request #28 from nox/early-servername
10e472f 
Allow returning more stuff from the early callback
@nox
Bump boring to 1.1.5
c85bf09
@inikulin
Merge pull request #29 from nox/bump
90a195c 
Bump boring to 1.1.5
@nox
Introduce ClientHello::client_version
fbdcfc3
@nox
Introduce HandshakeError::code
4473d08
@inikulin
Merge pull request #31 from nox/unexpected-eof
61e69eb 
Introduce HandshakeError::code
@inikulin
Merge pull request #30 from nox/client-version
dbc4e70 
Introduce ClientHello::client_version
@nox
Bump boring to 1.1.6
77ef82c
@inikulin
Merge pull request #32 from nox/bump
c8f13f2 
Bump boring to 1.1.6
@nox
Bump tokio-boring to 2.1.3
72e347d
@inikulin
Merge pull request #33 from nox/bump
9cb2e41 
Bump tokio-boring to 2.1.3
@simc
Fix padding
aee53a2
@simc
Update symm.rs
da3cc53
@simc
Make rustfmt happy
0024f43
@simc
Merge branch 'master' of https://github.com/isar/boring
e64317c
@inikulin
Copy link
Collaborator

inikulin commented Jun 1, 2021 •
edited
Loading

@leisim seems like needs a rebase and a regression test

nox pushed a commit to nox/boring that referenced this pull request Jul 28, 2023
@inikulin
Pull request cloudflare#21: Please update Docker base images to the l…
96a27c2 
…atest tags

Merge in OXY/boring-rpk from scrat/update-images-5cb0d33b14bb9ed955c8df0a25455c1f10646182 to master

* commit 'a55301dc68dcdc5e35808597c921804cbd40b915':
  SEC-3915 - Upgrade Docker base images to get the latest security updates
@nox
Copy link
Collaborator

nox commented Oct 9, 2023

@simc Ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wbl wbl Awaiting requested review from wbl

@vkrasnov vkrasnov Awaiting requested review from vkrasnov

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@simc @inikulin @nox