Open
Conversation
…t in scroll persistance
The problem: When document.readyState !== "loading" (which is the common case after initial page load), the code: 1. Calls initSidebarSearch() at line 294 (in the else block) 2. Immediately calls initSidebarSearch() again at line 298 (unconditionally) This creates duplicate event listeners for: - The search input's input event (line 243) - The search input's keydown event (line 250) - The global search link's click event (line 258) - The document's keydown event for "/" shortcut (line 265) The fix: Remove the unconditional call at line 298. The comment suggests it's for SPA-like navigation, but Astro handles view transitions differently, and this unconditional call is incorrect.
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
Preview URL: https://26fa2729.preview.developers.cloudflare.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The sidebar search initialization function was being called twice on page load when
document.readyState !== "loading":This caused duplicate event listeners to be attached for:
Solution
Removed the unconditional
initSidebarSearch()call at line 298. The conditional block already handles both scenarios correctly:Impact