SQC-792 add documentation for local hyperdrive environment files#28905
Open
Ltadrian wants to merge 3 commits intocloudflare:productionfrom
Open
SQC-792 add documentation for local hyperdrive environment files#28905Ltadrian wants to merge 3 commits intocloudflare:productionfrom
Ltadrian wants to merge 3 commits intocloudflare:productionfrom
Conversation
4 tasks
Contributor
|
/bonk review and address any findings. |
src/content/docs/hyperdrive/configuration/local-development.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/hyperdrive/configuration/local-development.mdx
Outdated
Show resolved
Hide resolved
| CLOUDFLARE_HYPERDRIVE_LOCAL_CONNECTION_STRING_HYPERDRIVE="postgres://user:password@localhost:5432/databasename" | ||
| ``` | ||
|
|
||
| Setting with a environment variable file will have higher precedence and override any environment variable set on your machine. |
Contributor
There was a problem hiding this comment.
Two issues:
- "a environment" → "an environment".
- The precedence claim needs verification. Line 84 already states that environment variables take precedence over the Wrangler config. Does the
.dev.varsfile truly override a shell-exported environment variable? Wrangler typically loads.dev.varsas environment variables itself, so a shell-exported var would usually win. Please verify the actual precedence and clarify the full order (env file vs. env var vs. wrangler config) so readers are not confused.
Suggested change
| Setting with a environment variable file will have higher precedence and override any environment variable set on your machine. | |
| Values set in an environment file take precedence over environment variables set on your machine. |
Contributor
|
Review posted. Here's a summary of what I flagged: HIGH
MEDIUM
The good news: the fix on line 13 (adding the missing word "edge") is correct and welcome. |
Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots (optional)
Documentation checklist