Skip to content

CC-4634: Add containers ssh docs#28923

Merged
gpanders merged 2 commits intoproductionfrom
ganders/CC-4634
Mar 13, 2026
Merged

CC-4634: Add containers ssh docs#28923
gpanders merged 2 commits intoproductionfrom
ganders/CC-4634

Conversation

@gpanders
Copy link
Member

@gpanders gpanders commented Mar 11, 2026

Summary

Continuation of #25076

Document the new(-ish) wrangler containers ssh command.

Screenshots (optional)

Documentation checklist

@github-actions
Copy link
Contributor

This PR requires additional review attention because it affects the following areas:

Partials

This PR updates partial files, which are pieces of content used across multiple files in our Render component.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/changelog/ @cloudflare/pm-changelogs, @cloudflare/pcx-technical-writing
/src/content/docs/containers/ @mikenomitch, @th0m, @cloudflare/pcx-technical-writing, @cloudflare/cloudchamber
/src/content/docs/workers/wrangler/ @cloudflare/wrangler, @irvinebroque, @cloudflare/pcx-technical-writing
/src/content/partials/workers/ @cloudflare/workers-docs, @GregBrimble, @irvinebroque, @mikenomitch, @WalshyDev, @cloudflare/deploy-config, @cloudflare/pcx-technical-writing, @cloudflare/wrangler, @mattietk

@gpanders
Copy link
Member Author

We should wait for cloudflare/workers-sdk#12853 to be released before merging this

@irvinebroque
Copy link
Contributor

changelog?

@gpanders gpanders requested a review from a team as a code owner March 12, 2026 20:45
@gpanders
Copy link
Member Author

changelog?

Added.

Will also need to wait for #28959 and cloudflare/workers-sdk#12873 to be merged since this PR contains a reference to the new wrangler containers instances command.

@gpanders

This comment was marked as duplicate.

irvinebroque

This comment was marked as duplicate.

@gpanders
Copy link
Member Author

/bonk review

1 similar comment
@mvvmm
Copy link
Contributor

mvvmm commented Mar 13, 2026

/bonk review

Copy link
Contributor

@ask-bonk ask-bonk bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted 4 inline suggestions.

@ask-bonk
Copy link
Contributor

ask-bonk bot commented Mar 13, 2026

Posted 4 inline suggestions on PR #28923. Summary of findings:

  • MEDIUMsrc/content/changelog/containers/2026-03-12-ssh-support.mdx:13-29: The Wrangler config snippet uses a bare jsonc code fence instead of the WranglerConfig component. Suggested wrapping it so readers see both JSON and TOML.
  • MEDIUMsrc/content/docs/containers/ssh.mdx:50: The link to #containers-instances on the wrangler commands page targets an anchor that does not exist yet (depends on PR Document "wrangler containers instances" command and add changelog #28959).
  • MEDIUMsrc/content/docs/containers/ssh.mdx:62: The link to #use-an-isolated-pid-namespace-for-containers on the compatibility flags page targets an anchor that does not exist. This will be a broken link at build time.
  • LOWsrc/content/docs/containers/ssh.mdx:62: Minor style fix — changed "enabled by default" to "turned on by default" per style guide conventions.

github run

gpanders and others added 2 commits March 13, 2026 16:34
Co-authored-by: flakey5 <73616808+flakey5@users.noreply.github.com>
Co-authored-by: emily-shen <69125074+emily-shen@users.noreply.github.com>
@gpanders gpanders merged commit 38ca320 into production Mar 13, 2026
21 checks passed
@gpanders gpanders deleted the ganders/CC-4634 branch March 13, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants