Skip to content

Conversation

evmos-lde
Copy link
Contributor

As I can see from the fixes here: GitHub Commit, the chart version has not been updated :-(

Could you please increment the chart version and create new packages? Thank you!

Feel free to use this improved version :)

@evmos-lde
Copy link
Contributor Author

evmos-lde commented Sep 1, 2023

@obezuk @bwesterb can you please review?

@denzhel
Copy link

denzhel commented Sep 4, 2023

We need this as well :)

We can regulate the cloudflared version via an image tag. Without this parameter, cloudflared will fail after update-freq time.
@evmos-lde
Copy link
Contributor Author

I have also disabled the auto-update of the binary in this PR. @bwesterb @obezuk — could you please, please, please review this? Thank you!

image

@digiserg
Copy link

digiserg commented Sep 5, 2023

I found the same issue and also created a PR before I saw this one, either will do for me:
#53

@uhthomas
Copy link
Contributor

uhthomas commented Sep 6, 2023

I would prefer to keep the auto-update PR separate (#51), but it is what it is.

Copy link
Contributor

@obezuk obezuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi folks, just got back from leave and catching up on this. This looks good and makes sense to disable auto update as the cloudflared version is tied to the chart.

@obezuk obezuk merged commit b85225e into cloudflare:main Sep 6, 2023
@obezuk obezuk mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants