workers assets shared routing cleanup by jbwcloudflare · Pull Request #14878 · cloudflare/workers-sdk

jbwcloudflare · 2026-07-27T17:29:42Z

Please see ticket above.
This change centralizes some of the URL handling for Workers Assets and Pages and begins recording telemetry to detect any impact that would be caused by updating all code to use the canonical URL handling.

This is telemetry-only for now.

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
- Additional testing not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: no behavioral change

A picture of a cute animal (not mandatory, but encouraged)

changeset-bot · 2026-07-27T17:29:50Z

🦋 Changeset detected

Latest commit: 406bd40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@cloudflare/workers-shared	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2026-07-27T17:33:14Z

@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@14878

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@14878

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14878

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14878

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14878

miniflare

npm i https://pkg.pr.new/miniflare@14878

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14878

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14878

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14878

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14878

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14878

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14878

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14878

wrangler

npm i https://pkg.pr.new/wrangler@14878

commit: 406bd40

workers-devprod · 2026-07-27T17:49:30Z

Codeowners approval required for this PR:

@cloudflare/deploy-config
@cloudflare/wrangler

Show detailed file reviewers

.changeset/thin-pianos-create.md: [@cloudflare/wrangler]
packages/workers-shared/asset-worker/src/analytics.ts: [@cloudflare/deploy-config @cloudflare/wrangler]
packages/workers-shared/asset-worker/src/handler.ts: [@cloudflare/deploy-config @cloudflare/wrangler]
packages/workers-shared/asset-worker/src/utils/canonical-path.ts: [@cloudflare/deploy-config @cloudflare/wrangler]
packages/workers-shared/asset-worker/src/utils/headers.ts: [@cloudflare/deploy-config @cloudflare/wrangler]
packages/workers-shared/asset-worker/src/utils/rules-engine.ts: [@cloudflare/deploy-config @cloudflare/wrangler]
packages/workers-shared/asset-worker/tests/canonical-path.test.ts: [@cloudflare/deploy-config @cloudflare/wrangler]
packages/workers-shared/asset-worker/tests/handler.test.ts: [@cloudflare/deploy-config @cloudflare/wrangler]
packages/workers-shared/asset-worker/tests/rules-engine.test.ts: [@cloudflare/deploy-config @cloudflare/wrangler]
packages/workers-shared/router-worker/src/analytics.ts: [@cloudflare/deploy-config @cloudflare/wrangler]
packages/workers-shared/router-worker/src/worker.ts: [@cloudflare/deploy-config @cloudflare/wrangler]
packages/workers-shared/router-worker/tests/index.test.ts: [@cloudflare/deploy-config @cloudflare/wrangler]

jbwcloudflare · 2026-07-27T17:51:54Z

marked as ready to get AI feedback, will fix any feedback and finalize afterwards

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

WillTaylorDev · 2026-07-28T12:48:20Z

@@ -0,0 +1,7 @@
+---
+"@cloudflare/workers-shared": minor


I think technically should be patch

the robot told me a telemetry change should be minor

but I'll do whatever the wrangler team wants here

WillTaylorDev · 2026-07-28T12:51:57Z

+	};
+}
+
+// Avoid decoding and matching work for paths that cannot change.


super nit: your comment actually is actually indicating the reverse of what this function does. The use of this does help us avoid work, but maybe this comment needs to move, or verbiage be flipped 😅

haha good call, this function was removed due to the bug you called out in the other comment

WillTaylorDev · 2026-07-28T13:35:17Z

+};
+
+// Returns both path representations so routing cannot accidentally reuse lookup input.
+export function canonicalizePath(pathname: string): CanonicalPath {


This reencodes each path segment, but the normalization bits and fast check only recognize % and //

For instance /docs+draft would canonicalize to /docs%2Bdraft, but the fast check returns false and the normalization mask would remain None. A literal /docs%2Bdraft rule would change decision and we wouldn't see any telemetry telemetry

ah good catch!

to avoid this kind of pitfall, I removed the "fast path" skip thing and decided to be more comprehensive and always run the comparison.

WillTaylorDev · 2026-07-28T13:38:23Z

+	None = 0,
+	Decoded = 1 << 0,
+	CollapsedSlashes = 1 << 1,
+	MalformedEncoding = 1 << 2,


We should also add a test for this case

refactor(workers-shared): extract routing match decisions

f91859a

workers-devprod added this to workers-sdk Jul 27, 2026

github-project-automation Bot moved this to Untriaged in workers-sdk Jul 27, 2026

jbwcloudflare force-pushed the jwheeler/WC-5564 branch from 2edf178 to 3f1b4c8 Compare July 27, 2026 17:39

jbwcloudflare marked this pull request as ready for review July 27, 2026 17:49

jbwcloudflare requested a review from workers-devprod as a code owner July 27, 2026 17:49

workers-devprod requested review from a team and penalosa and removed request for a team July 27, 2026 17:49

devin-ai-integration Bot reviewed Jul 27, 2026

View reviewed changes

WillTaylorDev reviewed Jul 28, 2026

View reviewed changes

jbwcloudflare force-pushed the jwheeler/WC-5564 branch from 3f1b4c8 to 107ab47 Compare July 28, 2026 14:00

This comment was marked as resolved.

Sign in to view

jbwcloudflare added 4 commits July 28, 2026 10:16

refactor(workers-shared): add canonical path matcher inputs

4931fdf

feat(asset-worker): record canonical path rule differences

f885467

feat(router-worker): record canonical routing differences

a45c310

chore: add Workers Assets telemetry changeset

406bd40

jbwcloudflare force-pushed the jwheeler/WC-5564 branch from 107ab47 to 406bd40 Compare July 28, 2026 14:17

jbwcloudflare requested a review from WillTaylorDev July 28, 2026 16:15

Uh oh!

Conversation

jbwcloudflare commented Jul 27, 2026 • edited by NuroDev Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

workers-devprod commented Jul 27, 2026

Uh oh!

jbwcloudflare commented Jul 27, 2026

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jbwcloudflare commented Jul 27, 2026 •

edited by NuroDev

Loading

changeset-bot Bot commented Jul 27, 2026 •

edited

Loading

pkg-pr-new Bot commented Jul 27, 2026 •

edited

Loading