Support version ranges and tags in wranglerVersion input#425
Closed
WillTaylorDev wants to merge 1 commit intocloudflare:mainfrom
Closed
Support version ranges and tags in wranglerVersion input#425WillTaylorDev wants to merge 1 commit intocloudflare:mainfrom
WillTaylorDev wants to merge 1 commit intocloudflare:mainfrom
Conversation
Member
|
This will actually work well with #412 |
ericclemmons
approved these changes
Apr 15, 2026
Member
ericclemmons
left a comment
ericclemmons
left a comment
There was a problem hiding this comment.
Much better DX for wranglerVersion! Good work!
The wranglerVersion input only accepted exact versions like '4.81.0'. Setting it to a major version like '4', a range like '^4.0.0', or a tag like 'latest' crashed with 'Invalid Version' during secret uploads. npm installed the right version fine, but subsequent version comparisons failed because they expected exact X.Y.Z format. After installing wrangler, the action now runs wrangler --version to get the concrete installed version and uses that for all version comparisons. If version detection fails and the user gave an exact version, the action falls back to using it directly, preserving existing behavior. Pre-installed versions that satisfy a range skip reinstallation. Fixes cloudflare#390 Relates to cloudflare#366 Relates to cloudflare#379
WillTaylorDev
force-pushed
the
willtaylor/escalation-963-support-version-ranges
branch
from
c9dd29c to
febbda6
Compare
This was referenced Apr 15, 2026
Member
|
Closed in favor of #426 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wranglerVersion input only accepted exact versions like '4.81.0'. Setting it to a major version like '4', a range like '^4.0.0', or a tag like 'latest' crashed with 'Invalid Version' during secret uploads. npm installed the right version fine, but subsequent version comparisons failed because they expected exact X.Y.Z format.
After installing wrangler, the action now runs wrangler --version to get the concrete installed version and uses that for all version comparisons. If version detection fails and the user gave an exact version, the action falls back to using it directly, preserving existing behavior.
Pre-installed versions that satisfy a range skip reinstallation.
Fixes #390
Relates to #366
Relates to #379