feat: upgrade to angular 17 #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime1992
reviewed
Mar 27, 2024
Comment on lines
+3
to
+5
| "ignorePatterns": [ | ||
| "projects/**/*" | ||
| ], |
There was a problem hiding this comment.
Please run yarn prettier:write see package.json. That'll run prettier and save a lot of diffs on the PR. Thanks
maxime1992
reviewed
Mar 27, 2024
| @@ -0,0 +1 @@ | |||
| nodeLinker: node-modules | |||
There was a problem hiding this comment.
Was this provided by the angular cli upgrade too or maybe because you're using yarn 2?
|
Remove the package json lock file. This repo uses yarn
(and run |
|
Mark the commit as a breaking change too
You can find other examples in the previous commits |
|
Thanks for the PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all dependencies