fix logging configuration when enabled and disabled#32
Open
gpetras wants to merge 2 commits intocloudposse:mainfrom
Open
fix logging configuration when enabled and disabled#32gpetras wants to merge 2 commits intocloudposse:mainfrom
gpetras wants to merge 2 commits intocloudposse:mainfrom
Conversation
hans-d
added
wip
|
/terratest |
|
@gpetras Hi, can you update the pr so that it passes the tests? otherwise, it is likely to be closed due to staleness. |
|
Thanks @gpetras for creating this pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while. While you wait, make sure to review our contributor guidelines. Tip Need help or want to ask for a PR review to be expedited?Join us on Slack in the |
hans-d
added
wip
|
/terratest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #31
what
The Firewall Manager logging configuration would not enable whether or not I supplied my own Kinesis Firehose or not. I tried to turn on
firehose_enabled, and I also tried to supply a Firehose ARN usingfirehose_arn, which I understand conflict with each other when used at the same time. This issue is fixedI also simplified the logic for generating the logging configuration, as I found it difficult to troubleshoot the multiple nested ternaries.
why
Fixes the logging configuration so that it properly logs to Kinesis Firehose w/ S3
references
closes #31