Skip to content

Conversation

fahmiauliarahman
Copy link

@fahmiauliarahman fahmiauliarahman commented Oct 10, 2025

What type of PR is this? docs

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

docs(文档): 在快速入门页面中添加 go mod edit apache/thrift v0.13.0 的说明

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: The "Getting Started" page introduces the hz tool using a .thrift file as an example. This change explicitly sets the apache/thrift version to v0.13.0 in the getting started instructions. This aligns our guide with the version used in the official Hertz Thrift Usage documentation. By specifying a known-compatible version, we can minimize potential version-mismatch errors and reduce confusion for new users following the tutorial.
zh(optional):

(Optional) Which issue(s) this PR fixes:

…rted section (because using .thrift as example)
@fahmiauliarahman fahmiauliarahman requested review from a team as code owners October 10, 2025 03:32
Copy link

netlify bot commented Oct 10, 2025

Deploy Preview for cloudwego ready!

Name Link
🔨 Latest commit 3918d2a
🔍 Latest deploy log https://app.netlify.com/projects/cloudwego/deploys/68e902ddfe08ef0007d78156
😎 Deploy Preview https://deploy-preview-1435--cloudwego.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2025

CLA assistant check
All committers have signed the CLA.

@fahmiauliarahman fahmiauliarahman changed the title docs: add go mod edit apache/thrift to v0.13.0 line on the getting started page docs(hertz): clarify thrift version requirement in getting started guide Oct 10, 2025
@GuangmingLuo
Copy link
Member

要改的话,中文文档为啥不一起改?

…on zh language

Add note about required thrift version (v0.13.0) for .thrift IDL usage to prevent potential compatibility issues

Signed-off-by: Fahmi Aulia Rahman <[email protected]>
@fahmiauliarahman
Copy link
Author

fahmiauliarahman commented Oct 10, 2025

you are right! i forgot to add the zh documentation. now it's added

你太紧张了。抱歉,我忘了更新 zh 文档,不过现在已经更新了。谢谢你的提醒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants