Skip to content

Conversation

@jayantxie
Copy link
Member

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 58 files.

Valid Invalid Ignored Fixed
54 4 0 0
Click to see the invalid file list
  • gridbuf/readbuf.go
  • gridbuf/readbuf_test.go
  • gridbuf/writebuf.go
  • gridbuf/writebuf_test.go

@jayantxie jayantxie marked this pull request as draft May 30, 2025 04:02
@jayantxie jayantxie force-pushed the feat/xwrite_buffer1 branch 2 times, most recently from e8534ea to 0d321bb Compare May 30, 2025 05:44
@jayantxie jayantxie force-pushed the feat/xwrite_buffer1 branch from 0d321bb to 75b6f5e Compare May 30, 2025 05:49
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 59 files.

Valid Invalid Ignored Fixed
58 1 0 0
Click to see the invalid file list
  • protocol/thrift/gridbuf_test.go

@@ -0,0 +1,118 @@
package thrift

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
package thrift
// Copyright 2025 CloudWeGo Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package thrift

@jayantxie jayantxie force-pushed the feat/xwrite_buffer1 branch from 3979caf to b6645e3 Compare May 30, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants