optimize(rpctimeout): defense user provided non-compliant ctx with ctx.Done() triggered but ctx.Err() returning nil#1949
Closed
DMwangnima wants to merge 1 commit intocloudwego:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1949 +/- ##
==========================================
+ Coverage 61.37% 62.71% +1.33%
==========================================
Files 388 393 +5
Lines 35063 30113 -4950
==========================================
- Hits 21521 18885 -2636
+ Misses 12247 9933 -2314
Partials 1295 1295
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
de74e0e to
a1fb208
Compare
…x.Done() triggered but ctx.Err() returning nil
a1fb208 to
4c2b01d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
optimize
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
当用户传入的 ctx 违反 context.Context 约定——Done() 已触发但 Err() 仍返回 nil(常见于自定义 "WithoutCancel" wrapper:embed 了父 context 导致继承其 Done(),却重写 Err() 为 nil)。会在 RPC 超时路径上引发 nil pointer panic:
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: