perf(gRPC): reduce object allocations on the gRPC client side for unified cancel scenarios#1950
Merged
DMwangnima merged 1 commit intocloudwego:mainfrom Apr 20, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1950 +/- ##
==========================================
+ Coverage 61.37% 62.63% +1.25%
==========================================
Files 388 393 +5
Lines 35063 30106 -4957
==========================================
- Hits 21521 18857 -2664
+ Misses 12247 9952 -2295
- Partials 1295 1297 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…fied cancel scenarios Split closeStream into casStreamDone and doCloseStream so that Tick can skip already-closed streams before constructing status/error objects. Introduce contextStatusAndErr returning reused singleton status and error for context.Canceled / context.DeadlineExceeded to avoid per-stream allocation. Guard shared status via Stream.reuseStatus flag and lazy deep copy in Stream.Status(). Remove unused eosReceived parameter from client-side closeStream. Add reuseStatus defense tests and closeStreamTask Tick benchmarks.
427953f to
779b183
Compare
DMwangnima
commented
Apr 20, 2026
YangruiEmma
approved these changes
Apr 20, 2026
ppzqh
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
perf
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: