-
Notifications
You must be signed in to change notification settings - Fork 124
support apiserver url rewrite #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @huiwq1990, DetailsInstructions for interacting with me using comments are available here. |
66b6460 to
b411cb5
Compare
|
If If you choose to remove the prefix, then |
b411cb5 to
c09bdce
Compare
@Iceber I made some change, and remove |
c25ffe2 to
c8ff14b
Compare
|
@wzshiming The old version, I want to implement a general rewriter, it's too complex for us. So I did some refactor, it's easy to understand. |
c8ff14b to
305d1e9
Compare
305d1e9 to
1ec220c
Compare
|
LGTM /cc @Iceber |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some points for discussion
1ec220c to
b402e62
Compare
b402e62 to
99f0dce
Compare
Signed-off-by: huiwq1990 <[email protected]>
99f0dce to
77f3455
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
Expose the binding-apiserver more kubernete.
Which issue(s) this PR fixes:
Fixes #589
Special notes for your reviewer:
--feature-gates=ApiServerURLRewrite=trueto open the feature.Does this PR introduce a user-facing change?: