Rename composite32 to composite, instead of having both
#21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `composite` function in Pixman is defined to just call `composite32` (for compatibility with ancient code from before that was added). So there's no need to expose both in Rust bindings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
compositefunction in Pixman is defined to just callcomposite32(for compatibility with ancient code from before that was added). So there's no need to expose both in Rust bindings.This is a breaking API change.
I'm not sure if
Region16is useful to keep as a type, or just unnecessary. Internally, Pixman just usespixman_region32_copy_from_region16to convert it to aRegion32...