Fixes #1 The soldermask is now on the top layer for 0402 LED package#2
Open
dmsherazi wants to merge 1 commit intocmonr:masterfrom
Open
Fixes #1 The soldermask is now on the top layer for 0402 LED package#2dmsherazi wants to merge 1 commit intocmonr:masterfrom
dmsherazi wants to merge 1 commit intocmonr:masterfrom
Conversation
cmonr
requested changes
Apr 27, 2021
Owner
cmonr
left a comment
cmonr
left a comment
There was a problem hiding this comment.
Take the following suggestions and I can merge this in!
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!DOCTYPE eagle SYSTEM "eagle.dtd"> | ||
| <eagle version="6.5.0"> | ||
| <eagle version="9.6.2"> |
Owner
There was a problem hiding this comment.
Suggested change
| <eagle version="9.6.2"> | |
| <eagle version="6.5.0"> |
| <drawing> | ||
| <settings> | ||
| <setting alwaysvectorfont="no"/> | ||
| <setting keepoldvectorfont="yes"/> |
Owner
There was a problem hiding this comment.
Suggested change
| <setting keepoldvectorfont="yes"/> |
| <setting verticaltext="up"/> | ||
| </settings> | ||
| <grid distance="0.25" unitdist="mm" unit="mm" style="dots" multiple="2" display="yes" altdistance="0.05" altunitdist="mm" altunit="mm"/> | ||
| <grid distance="50" unitdist="mil" unit="mil" style="dots" multiple="1" display="yes" altdistance="5" altunitdist="mil" altunit="mil"/> |
Owner
There was a problem hiding this comment.
Suggested change
| <grid distance="50" unitdist="mil" unit="mil" style="dots" multiple="1" display="yes" altdistance="5" altunitdist="mil" altunit="mil"/> | |
| <grid distance="0.25" unitdist="mm" unit="mm" style="dots" multiple="2" display="yes" altdistance="0.05" altunitdist="mm" altunit="mm"/> |
Owner
|
Man, wasn't even aware that others were still using this library collection. It's safe to say that this repo is out of date and unmaintained, but this is a small enough change that can be brought in w/o testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.