-
Notifications
You must be signed in to change notification settings - Fork 200
[15.0]Backport root bug fixes and generation of cuda.pcm #9899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: IB/CMSSW_15_0_X/master
Are you sure you want to change the base?
Conversation
|
please test |
|
A new Pull Request was created by @smuzaffar for branch IB/CMSSW_15_0_X/master. @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test TestDQMGUIUpload had ERRORS Comparison SummarySummary:
|
|
please test lets refresh the tests |
|
@makortel , this PR backports ROOT 6.32 latest changes in to 15.0.X release cycles. This tag of root 6.32 has been in 15.1.X since CMSSW_15_1_X_2025-05-27-1100 (over 5 days now). Do you want to wait bit more before integrating it in 15.0.X ? |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5663d7/46488/summary.html Comparison SummarySummary:
|
I think we need to wait. We have cms-sw/cmssw#48171 that seems to be related to the ROOT update in 15_1_X. |
|
hold |
|
Pull request has been put on hold by @smuzaffar |
In the end the cms-sw/cmssw#48171 turned out to have a different cause. I don't think we have seen problems with the ROOT 6.32 update in 15_1_X, so I suppose the backport to 15_0_X could continue. |
|
Do we still need this backport for 15.0.X ? If really not needed then I would suggest to close this PR. |
This PR backports various root fixes from 15.1.X release cycles to 15.0.X
cuda.pcmcmssw#47400cmathinstead ofmath.hto avoud cuda.pcm issues