Skip to content

Conversation

@smuzaffar
Copy link
Contributor

This PR backports various root fixes from 15.1.X release cycles to 15.0.X

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_15_0_X/master.

@iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 30, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5663d7/46453/summary.html
COMMIT: 61efffc
CMSSW: CMSSW_15_0_X_2025-05-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9899/46453/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor Author

please test

lets refresh the tests

@smuzaffar
Copy link
Contributor Author

@makortel , this PR backports ROOT 6.32 latest changes in to 15.0.X release cycles. This tag of root 6.32 has been in 15.1.X since CMSSW_15_1_X_2025-05-27-1100 (over 5 days now). Do you want to wait bit more before integrating it in 15.0.X ?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5663d7/46488/summary.html
COMMIT: 61efffc
CMSSW: CMSSW_15_0_X_2025-06-01-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9899/46488/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@makortel
Copy link
Contributor

makortel commented Jun 2, 2025

@makortel , this PR backports ROOT 6.32 latest changes in to 15.0.X release cycles. This tag of root 6.32 has been in 15.1.X since CMSSW_15_1_X_2025-05-27-1100 (over 5 days now). Do you want to wait bit more before integrating it in 15.0.X ?

I think we need to wait. We have cms-sw/cmssw#48171 that seems to be related to the ROOT update in 15_1_X.

@smuzaffar
Copy link
Contributor Author

hold

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2025

Pull request has been put on hold by @smuzaffar
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Jun 5, 2025
@makortel
Copy link
Contributor

makortel commented Jul 3, 2025

@makortel , this PR backports ROOT 6.32 latest changes in to 15.0.X release cycles. This tag of root 6.32 has been in 15.1.X since CMSSW_15_1_X_2025-05-27-1100 (over 5 days now). Do you want to wait bit more before integrating it in 15.0.X ?

I think we need to wait. We have cms-sw/cmssw#48171 that seems to be related to the ROOT update in 15_1_X.

In the end the cms-sw/cmssw#48171 turned out to have a different cause. I don't think we have seen problems with the ROOT 6.32 update in 15_1_X, so I suppose the backport to 15_0_X could continue.

@smuzaffar
Copy link
Contributor Author

Do we still need this backport for 15.0.X ? If really not needed then I would suggest to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants